-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Rewrite search functionality using Paging #5528
Merged
Isira-Seneviratne
merged 4 commits into
libre-tube:master
from
Isira-Seneviratne:Paging_search
Jan 25, 2024
Merged
refactor: Rewrite search functionality using Paging #5528
Isira-Seneviratne
merged 4 commits into
libre-tube:master
from
Isira-Seneviratne:Paging_search
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Paging_search
branch
from
January 22, 2024 00:42
11d4246
to
5e17bb4
Compare
Isira-Seneviratne
changed the title
refactor: Rewrite search adapter using Paging
refactor: Rewrite search functionality using Paging
Jan 22, 2024
Isira-Seneviratne
force-pushed
the
Paging_search
branch
2 times, most recently
from
January 22, 2024 01:08
33e8a63
to
4208531
Compare
Isira-Seneviratne
force-pushed
the
Paging_search
branch
from
January 22, 2024 01:15
a0f4c69
to
bf227fa
Compare
Bnyro
reviewed
Jan 22, 2024
app/src/main/java/com/github/libretube/ui/models/sources/SearchPagingSource.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Jan 22, 2024
app/src/main/java/com/github/libretube/ui/adapters/callbacks/SearchCallback.kt
Outdated
Show resolved
Hide resolved
Bnyro
requested changes
Jan 23, 2024
app/src/main/java/com/github/libretube/ui/adapters/SearchChannelAdapter.kt
Show resolved
Hide resolved
…elAdapter.kt Co-authored-by: Bnyro <82752168+Bnyro@users.noreply.github.com>
|
Bnyro
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thanks 👍
(Please rebase or squash before merging)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the search functionality using the Paging library.